[Metax] fix accuracy error of scatter in metax #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galaxy1458
reviewed
Feb 27, 2025
src/flag_gems/ops/scatter.py
Outdated
| @@ -17,6 +17,7 @@ def generate_imports(code: IndentedBuffer) -> IndentedBuffer: | |||
| code.newline() | |||
| code.writeline("from flag_gems.utils import libentry") | |||
| code.writeline("from flag_gems import runtime") | |||
| code.writeline("from flag_gems.runtime import device") | |||
There was a problem hiding this comment.
import flag_gems and now has attr vendor_name, metax can use flag_gems.vendor_name,
src/flag_gems/ops/scatter.py
Outdated
| @@ -35,6 +36,9 @@ def generate_scatter_kernel( | |||
|
|
|||
| code.writeline("def heur_block(args):") | |||
| with code.indent(): | |||
| code.writeline("if(device.get_vendor_name()=='metax'):") | |||
Galaxy1458
reviewed
Feb 27, 2025
src/flag_gems/ops/scatter.py
Outdated
| @@ -17,6 +17,7 @@ def generate_imports(code: IndentedBuffer) -> IndentedBuffer: | |||
| code.newline() | |||
| code.writeline("from flag_gems.utils import libentry") | |||
| code.writeline("from flag_gems import runtime") | |||
| code.writeline("from flag_gems") | |||
There was a problem hiding this comment.
import flag_gems, not from flag_gems
mx-flaggems-user
force-pushed
the
master
branch
from
1b68e14 to
71f4ea0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operater
Type of Change
Bug Fix
Description
We found that scatter with
heur_block=128will calculate wrong answer, so need to change it to 256 while running in metax backend